Public Release for Fall24 meta-release #101
Conversation
Readme copied from @FabrizioMoggio PR + fixed @tanjadegroot issues
Copied from @FabrizioMoggio PR + fixed api name in link as proposed by @tanjadegroot
Fixed api name in links
Copied from @FabrizioMoggio PR + fixed the 2 typos identified by @tanjadegroot
Copied from @FabrizioMoggio PR + fixed api yaml name + used link
Copied from @FabrizioMoggio + fixed type in line 229 (@tanjadegroot )
bigludo7
requested review from
FabrizioMoggio and
chinaunicomyangfan
as code owners
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
|
@tanjadegroot For context: @FabrizioMoggio has issue with easyCLA so I copied his PR. on line 229: does unconditional forwarding overwrite conditional forwarding if both are active ? on line 230: with "This endpoint exceeds the main scope of the CFS API, for this reason an error code 501 can be returned" do you mean that this second endpoint is optional and may not be provided and that 501 is returned in that case ? |
CHANGELOG.md
Outdated
| - OpenAPI [YAML spec file](https://github.com/camaraproject/CallForwardingSignal/blob/r1.1/code/API_definitions/call-forwarding-signal.yaml) | ||
| - [View it on ReDoc](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/camaraproject/CallForwardingSignal/r1.1/code/API_definitions/call-forwarding-signal.yaml&nocors) | ||
| - [View it on Swagger Editor](https://editor.swagger.io/?url=https://raw.githubusercontent.com/camaraproject/CallForwardingSignal/r1.1/code/API_definitions/call-forwarding-signal.yaml) |
There was a problem hiding this comment.
@bigludo7 here in r1.1 the filename will stay unchanged ... the links work and will work perfectly. Don't try to change the history 😄
There was a problem hiding this comment.
Fixed .... but we do not have an issue fir r1.2-rc because not sure where the links points to.
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Rename yaml file
updated the link for the r1.1
_on line 229: my sentence was actually intended to just say that more than one kind of call forwarding service can be active at the same time and that the API will provide back every kind of service that is configured. The main kind are unconditional and conditional than we can have different flavors of conditional. The logic of what can be configured in the Network and the priorities of the call fwd services have no effect on the API. Anyway I agree, if the they are both active in the same timeslot, unconditional takes the precedence. -on line 230: some additional information here: #37 (comment) |
| @@ -15,23 +15,22 @@ Repository to describe, develop, document and test the Call Forwarding Signal AP | |||
| * The Application Server invokes the Call Forwarding Signal API to determine if a specific phone number has an active "call forwarding" setup. "Call forwarding" is a network service that redirects incoming calls to another phone number (configured in the service). The Call Forwarding Signal API can be used by a bank to verify if a “call forwarding” option is active on the customer’s phone number to avoid frauds. A call from the bank to the customers can indeed be forwarded to a different number because of a fraud attempt. | |||
| * The API is useful to avoid frauds. Banks offer the option for users to receive telephone calls to solve problems, e.g. in case of issues with the bank App, issues with Smartphones, the bank website or any tool providing access to the online bank account management system.<br>How does the fraudster operate?<br>• Through social engineering, the fraudster gathers information about bank customers who are engaged in such a situation, needing the bank to contact them.<br>• Once they identify the service provider and phone number of a customer, they manage to successfully activate, on the customer profile, the 'call forwarding' to a phone number they control.<br>• After successfully setting up 'call forwarding,' the fraudster then contacts the bank, claiming an inability to access online banking services and requesting a call from a bank representative. <br>• When the bank calls the registered contact number of the user, the active 'call forwarding' diverts the call directly to the fraudster, thus completing their scheme.<br> The Call Forwarding Signal API can be used by the bank to verify if a "call forwarding" option is active on the customer's phone, avoiding such a fraud. | |||
| * Describe, develop, document and test the APIs (with 1-2 Telcos) | |||
| * Started: February 2024 | |||
| * Location: virtually | |||
| * Started: February 2024 | |||
|
|
|||
| ## Meetings | |||
| * Meetings are held virtually | |||
There was a problem hiding this comment.
@bigludo7 we should remove or line 21 or line 23
Remove line 23
According to the discussion in: V0.2.0 M4 by FabrizioMoggio · Pull Request #95 · camaraproject/CallForwardingSignal (github.com)
M4 version for Fall24:
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
final release for Fall24
Which issue(s) this PR fixes:
#94
#93
#96
#97
#98
#100
Special notes for reviewers:
PR done on behalf of @FabrizioMoggio
Changelog input
Additional documentation
This section can be blank.