-
Notifications
You must be signed in to change notification settings - Fork 2
application profiles r1.2 Fall25 M4 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bigludo7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
First review on behalf of the Release Review management team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should consider camaraproject/Commonalities#506 for ErrorMessage. message and code attribute description have to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated ErrorInfo
documentation/API_documentation/application-profiles-API-Readiness-Checklist.md
Show resolved
Hide resolved
|
Hello @maheshc01 - gentle reminder for these few requests as the M4 deadline coming soon. |
|
Hi @bigludo7 , Thank you for the comments. I have updated the files based on your suggestions. |
|
Thanks a lot @urvika-v Sorry for that. I should be this sorting: (with May I request you to apply this please. |
|
Hello @bigludo7 |
bigludo7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @urvika-v
Approved on behalf of Release Management 👏
Next steps for the team:
• [ ] PR merged (by API repository codeowner)
• [ ] Release created within GitHub (by API repository codeowner)
• [ ] Release Tracker updated (with creation date of the release and the release tag link)
Thanks
|
Thanks @maheshc01 All set - you can merge, create the release & update the wiki page now :) - Thanks for your contribution. |
|
Thank you for your review and the go ahead @bigludo7 |
urvika-v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
HI Team, will you be able to merge, publish the release and update the release tracker on wiki before tomorrow's TSC (at 4PM CEST) ? |
|
thank you all. will go ahead and merge the branch and create the public release. |
What type of PR is this?
What this PR does / why we need it:
Fall 25 M4 release
Which issue(s) this PR fixes:
Fixes # na
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.