Skip to content

Conversation

@maheshc01
Copy link
Contributor

What type of PR is this?

  • repository management

What this PR does / why we need it:

Fall 25 M4 release

Which issue(s) this PR fixes:

Fixes # na

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

Copy link

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR
First review on behalf of the Release Review management team

Copy link

@bigludo7 bigludo7 Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should consider camaraproject/Commonalities#506 for ErrorMessage. message and code attribute description have to be updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated ErrorInfo

@bigludo7
Copy link

Hello @maheshc01 - gentle reminder for these few requests as the M4 deadline coming soon.
Thanks

@urvika-v
Copy link
Contributor

Hi @bigludo7 , Thank you for the comments. I have updated the files based on your suggestions.
Could you please review.

@bigludo7
Copy link

Thanks a lot @urvika-v
I realize I did not point you to the latest discussion for the ErrorInfo - It should be camaraproject/Commonalities#517

Sorry for that. I should be this sorting: (with message last):

ErrorInfo:
      type: object
      required:
        - status
        - code
        - message
      properties:
        status:
          type: integer
          description: HTTP response status code
        code:
          type: string
          description: A human-readable code to describe the error
        message:
          type: string
          description: A human-readable description of what the event represents

May I request you to apply this please.
Thank

@urvika-v
Copy link
Contributor

Hello @bigludo7
I have updated the ErrorInfo. Please review

Copy link

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @urvika-v

Approved on behalf of Release Management 👏

Next steps for the team:
• [ ] PR merged (by API repository codeowner)
• [ ] Release created within GitHub (by API repository codeowner)
• [ ] Release Tracker updated (with creation date of the release and the release tag link)

Thanks

@bigludo7
Copy link

And please @urvika-v could you provide also answer to #21.
This is also a prerequisite. Thanks

@maheshc01
Copy link
Contributor Author

And please @urvika-v could you provide also answer to #21. This is also a prerequisite. Thanks

Hi @bigludo7, I have put in my comment for #21 . the wiki page has been updated to include the changes done as part of the latest release.

@bigludo7
Copy link

Thanks @maheshc01

All set - you can merge, create the release & update the wiki page now :) - Thanks for your contribution.

@maheshc01
Copy link
Contributor Author

Thank you for your review and the go ahead @bigludo7

@maheshc01
Copy link
Contributor Author

@urvika-v and @Kevsy for going ahead with the merge i would still require one of you to approve this.
Could you please mark this as approved.

Copy link
Contributor

@urvika-v urvika-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanjadegroot
Copy link

HI Team, will you be able to merge, publish the release and update the release tracker on wiki before tomorrow's TSC (at 4PM CEST) ?
thanks to all !!

@maheshc01
Copy link
Contributor Author

thank you all. will go ahead and merge the branch and create the public release.

@maheshc01 maheshc01 merged commit ca8fb2a into camaraproject:main Sep 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants