Skip to content

Conversation

@Kamran-Keykhosravi
Copy link
Contributor

What type of PR is this?

  • enhancement/feature
    API proposal

What this PR does / why we need it:

Adds the API proposal (API-proposal-Attenuation_Rainfall.md) and slides for presentation (API-proposal-Attenuation_Rainfall.pptx)

Which issue(s) this PR fixes:

Fixes #267

Special notes for reviewers:

Changelog input

documentation/API proposals/API-proposal-Attenuation_Rainfall.md
        documentation/SupportingDocuments/API-proposal-Attenuation_Rainfall.pptx

Additional documentation

This section can be blank.

docs

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 20, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@albertoramosmonagas
Copy link
Contributor

Hi @Kamran-Keykhosravi! Thank you for uploading the API proposal with the documentation; it greatly assists the process. The issue with:

CLA Not Signed

In order for us to approve the proposal in the future, the easyCLA error needs to be resolved. You simply need to click the link and sign the authorization: easyCLA check.

@albertoramosmonagas
Copy link
Contributor

Hello @Kamran-Keykhosravi

Just a quick question, by any chance, is this the solution behind the API? Ericsson Weather Data

@Kamran-Keykhosravi
Copy link
Contributor Author

Hello @Kamran-Keykhosravi

Just a quick question, by any chance, is this the solution behind the API? Ericsson Weather Data

Hello Alberto,
Yes the solution you referred is related to this API.

Bests,
Kamran.

@Kamran-Keykhosravi
Copy link
Contributor Author

  • EasyCLA check passed. You are authorized to contribute.

Hello Alberto,

Now the CLA issue is seemed to be solved at my end. Can you please check and let me know if I should do anything else.

Bests,
Kamran.

@Kamran-Keykhosravi
Copy link
Contributor Author

Hello @albertoramosmonagas .
We are working on modifying this API proposal based on the comments. I was just wondering if I should create a new pull request for the revised API description or do something else.

@albertoramosmonagas
Copy link
Contributor

ription or do something else.

Hi @Kamran-Keykhosravi, The point we left in the backlog was:

AP: Ericsson will have an internal discussion to see if they want to change anything related to the collected feedback and, if not, notify the backlog to review the PR and send it to TSC for approval.

There's no problem using this same PR to implement those changes. However, it would be good to clearly state which changes have been applied. If you want to create another PR and close this one, that's fine, as long as everything is documented and linked to the original issue.

### API family owner
Ericsson

### API summary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kamran-Keykhosravi, as a suggestion for improving the wording of this paragraph, I would propose the following:

  • First sentence: what the API provides in plain language (“near real-time rainfall data using the operator's network”).
  • Second: how it does this at a high level (it uses radio links between antennas that are affected by rain).
  • Third: what it is used for (rain models, forecasting, drones, etc.).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alberto, thanks for the suggestion.

I am generally OK with the suggested changes. I added the sentence "Furthermore, the API provides near real-time rainfall data by leveraging radio links in the operator's network, which can be affected by rain." at the end of paragraph 1, to address the first two suggestion.

About the third one, drones are already mentioned in "Commercial viability" section I added a sentence to the beginning of paragraph 2 to include "Also, it can be used for weather forecasting and to improve the rain models. "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albertoramosmonagas Can we discuss the changes in the next meeting (11th)?

Addressing comments in November meeting
…l-Strength_Rainfall.md

Renamed the file and also the API family name by changing attenuation to strength.
@Kamran-Keykhosravi
Copy link
Contributor Author

Hi @albertoramosmonagas
I renamed the file and also the API family name by replacing attenuation to strength as suggested. Please let me know if further updates are required.

@albertoramosmonagas
Copy link
Contributor

Hi @Kamran-Keykhosravi, thanks for the renaming, but don't forget change the title: API proposal- Radio signal attenuation API (for rainfall analysis use cases) #268 --> to API proposal- Radio signal strength API (for rainfall analysis use cases) #268

@albertoramosmonagas
Copy link
Contributor

@camaraproject/api-backlog_codeowners - We need a review. Since the backlog session on December 11, there have been no objections (https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/389414929/2025-12-11+API+Backlog+Minutes). The idea is to send it to the next TSC on December 18.

@Kamran-Keykhosravi Kamran-Keykhosravi changed the title API proposal- Radio signal attenuation API (for rainfall analysis use cases) API proposal- Radio signal strength API (for rainfall analysis use cases) Dec 11, 2025
@Kamran-Keykhosravi
Copy link
Contributor Author

Hi @Kamran-Keykhosravi, thanks for the renaming, but don't forget change the title: API proposal- Radio signal attenuation API (for rainfall analysis use cases) #268 --> to API proposal- Radio signal strength API (for rainfall analysis use cases) #268

Done!

@Kamran-Keykhosravi
Copy link
Contributor Author

Hi @albertoramosmonagas ,
Would it be OK to change the API name and the PR to "Rainfall Intensity and signal API"? I think it is more informative.

@albertoramosmonagas
Copy link
Contributor

Hi @albertoramosmonagas , Would it be OK to change the API name and the PR to "Rainfall Intensity and signal API"? I think it is more informative.

No problem for me, but let me add this point to the next meeting of the TSC (tomorrow to handle the issue)

Copy link
Collaborator

@jgarciahospital jgarciahospital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@albertoramosmonagas albertoramosmonagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgarciahospital jgarciahospital merged commit 87cc10a into camaraproject:main Dec 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API Proposal] Radio signal attenuation API (for rainfall analysis use cases)

3 participants