-
Notifications
You must be signed in to change notification settings - Fork 46
API proposal- Radio signal strength API (for rainfall analysis use cases) #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API proposal- Radio signal strength API (for rainfall analysis use cases) #268
Conversation
|
Hi @Kamran-Keykhosravi! Thank you for uploading the API proposal with the documentation; it greatly assists the process. The issue with:
In order for us to approve the proposal in the future, the easyCLA error needs to be resolved. You simply need to click the link and sign the authorization: easyCLA check. |
|
Hello @Kamran-Keykhosravi Just a quick question, by any chance, is this the solution behind the API? Ericsson Weather Data |
Hello Alberto, Bests, |
Hello Alberto, Now the CLA issue is seemed to be solved at my end. Can you please check and let me know if I should do anything else. Bests, |
|
Hello @albertoramosmonagas . |
Hi @Kamran-Keykhosravi, The point we left in the backlog was: AP: Ericsson will have an internal discussion to see if they want to change anything related to the collected feedback and, if not, notify the backlog to review the PR and send it to TSC for approval. There's no problem using this same PR to implement those changes. However, it would be good to clearly state which changes have been applied. If you want to create another PR and close this one, that's fine, as long as everything is documented and linked to the original issue. |
| ### API family owner | ||
| Ericsson | ||
|
|
||
| ### API summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kamran-Keykhosravi, as a suggestion for improving the wording of this paragraph, I would propose the following:
- First sentence: what the API provides in plain language (“near real-time rainfall data using the operator's network”).
- Second: how it does this at a high level (it uses radio links between antennas that are affected by rain).
- Third: what it is used for (rain models, forecasting, drones, etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Alberto, thanks for the suggestion.
I am generally OK with the suggested changes. I added the sentence "Furthermore, the API provides near real-time rainfall data by leveraging radio links in the operator's network, which can be affected by rain." at the end of paragraph 1, to address the first two suggestion.
About the third one, drones are already mentioned in "Commercial viability" section I added a sentence to the beginning of paragraph 2 to include "Also, it can be used for weather forecasting and to improve the rain models. "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albertoramosmonagas Can we discuss the changes in the next meeting (11th)?
Addressing comments in November meeting
…l-Strength_Rainfall.md Renamed the file and also the API family name by changing attenuation to strength.
|
Hi @albertoramosmonagas |
|
Hi @Kamran-Keykhosravi, thanks for the renaming, but don't forget change the title: API proposal- Radio signal attenuation API (for rainfall analysis use cases) #268 --> to API proposal- Radio signal strength API (for rainfall analysis use cases) #268 |
|
@camaraproject/api-backlog_codeowners - We need a review. Since the backlog session on December 11, there have been no objections (https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/389414929/2025-12-11+API+Backlog+Minutes). The idea is to send it to the next TSC on December 18. |
Done! |
|
Hi @albertoramosmonagas , |
No problem for me, but let me add this point to the next meeting of the TSC (tomorrow to handle the issue) |
jgarciahospital
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
albertoramosmonagas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
API proposal
What this PR does / why we need it:
Adds the API proposal (API-proposal-Attenuation_Rainfall.md) and slides for presentation (API-proposal-Attenuation_Rainfall.pptx)
Which issue(s) this PR fixes:
Fixes #267
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.