Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares the codebase for a v4.0.0 release by bumping version numbers, fixing a typo in the README, and resolving mypy strict mode type checking errors.
- Version numbers updated from 3.2.0 to 4.0.0 across configuration files
- Corrected typo in README.md ("airfoil" → "airfoils")
- Added specific Callable type signatures and type ignore comments to satisfy mypy --strict mode
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| setup.cfg | Updated package version to 4.0.0 |
| make_installer.iss | Updated installer version to 4.0.0 |
| README.md | Fixed grammar: "airfoil" to "airfoils" |
| pterasoftware/output.py | Added type ignore comments for webp.Image.fromarray calls |
| pterasoftware/movements/wing_movement.py | Added explicit Callable type signatures for spacing parameters |
| pterasoftware/movements/wing_cross_section_movement.py | Added explicit Callable type signatures for spacing parameters |
| pterasoftware/movements/operating_point_movement.py | Added numpy import and explicit Callable type signature |
| pterasoftware/movements/airplane_movement.py | Added explicit Callable type signatures for spacing parameters |
| pterasoftware/movements/_functions.py | Added explicit Callable type signature for custom_function parameter |
| pterasoftware/geometry/airplane.py | Added type ignore comment for webp.Image.fromarray call |
| pterasoftware/_parameter_validation.py | Updated return types with explicit Callable signatures and changed list to list[Any] |
| pterasoftware/_functions.py | Added type ignore comments for @njit decorators |
| pterasoftware/_aerodynamics.py | Added type ignore comments for @njit decorators |
…ng mypy's --strict flag
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work to prepare for releasing the latest version!
Changes
--strictflag (we're continuing to run mypy without this flag for CI and development, but I figured it couldn't hurt)Change Magnitude
Minor: Small change such as a bug fix, small enhancement, or documentation update.
Checklist
mainand is up to date with the upstreammainbranch.--in-place --black).testspackage.testspackage.codespell,black,mypy, andtests).