Save and restore last search term via AsyncStorage
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/DebugSceneList.js
Outdated
| alignItems: 'center', | ||
| }, | ||
| componentWrapper: { | ||
| marginHorizontal: 20, |
Contributor
There was a problem hiding this comment.
I thought we didn't want this and instead set the margin on Individual components if needed.
Contributor
Author
There was a problem hiding this comment.
You're right - thanks. That was accidentally re-added.
src/DebugSceneList.js
Outdated
| return ( | ||
| <View key={'modal1'} style={[styles.selectedComponentWrapper, this.state.selectedItem && this.state.selectedItem.wrapperStyle]}> | ||
| <View | ||
| key={'modal1'} |
Contributor
There was a problem hiding this comment.
We could use here a better name, maybe something like: component-viewer-container-modal
Contributor
pablocarrillo
left a comment
pablocarrillo
left a comment
There was a problem hiding this comment.
Code looks good to me, couple of suggestions inline. I will try the branch later before approval
Contributor
|
Tested and works as expected, lets bump the version in the package.json and merge:) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the list will save and restore your last search term via
AsyncStorage. This is useful if you have many registered tests, as it saves you from having to type the search term every time you reload.Saving your last search can be disabled by setting the optional
saveSearchprop tofalseonComponentViewer. The default istrue.Also added calvium's ESLint configuration, and make the code pass.
Covers #12