Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FileShare commands. #84

Merged
merged 9 commits into from
May 4, 2022
Merged

Added FileShare commands. #84

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
708f310
Added FileShare commands.
May 3, 2022
2966fec
Updated params to match spec. Added param help.
May 3, 2022
7d584e2
Added help. Removed --ids support.
May 3, 2022
44ecce9
Removed automatic import statements.
May 3, 2022
8a4c22e
Added back type in help.
May 3, 2022
02eec4d
Added tests.
May 3, 2022
7b3bc87
Updated param names to better reflect AzureFile dependency.
May 3, 2022
d1582c7
Added validation to ensure share name and account name are longer tha…
May 3, 2022
e992b72
Added warning message if user is updating existing storage.
May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed automatic import statements.
  • Loading branch information
Haroon Feisal committed May 3, 2022
commit 44ecce98b7d2afffdcba05c09fa0c0df0de75523
1 change: 0 additions & 1 deletion src/containerapp/azext_containerapp/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
# --------------------------------------------------------------------------------------------
# pylint: disable=line-too-long, too-many-statements, consider-using-f-string

from wsgiref.validate import validator
from knack.arguments import CLIArgumentType

from azure.cli.core.commands.parameters import (resource_group_name_type, get_location_type,
Expand Down
2 changes: 1 addition & 1 deletion src/containerapp/azext_containerapp/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
# --------------------------------------------------------------------------------------------
# pylint: disable=line-too-long, consider-using-f-string, logging-format-interpolation, inconsistent-return-statements, broad-except, bare-except, too-many-statements, too-many-locals, too-many-boolean-expressions, too-many-branches, too-many-nested-blocks, pointless-statement, expression-not-assigned, unbalanced-tuple-unpacking

from os import access
import threading
import sys
import time
Expand Down Expand Up @@ -2226,6 +2225,7 @@ def create_or_update_storage(cmd, storage_name, resource_group_name, name, accou
if type.lower() != "azurefile":
raise ValidationError("Only AzureFile type is supported at this time.")

# We will replace this with sdk at some point
storage_def = AzureFilePropertiesModel
storage_def["accountKey"] = account_key
storage_def["accountName"] = account_name
Expand Down