Repository navigation
fix: pick busiest CPU profile from multi-thread traces - #24
Merged
hurali97 merged 1 commit intoOct 8, 2026
Merged
Conversation
TMisiukiewicz
marked this pull request as ready for review
October 8, 2026 11:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Chrome Performance traces can hold more than one CPU profile, one for each JS thread that was recording (main renderer, other tabs, service workers). Tracesift keeps only one of them, and it picked the profile with the most samples.
An idle thread can easily have the most samples. In the trace that exposed this, the service worker had 100k samples, but almost all of them were
(idle), so it beat the main renderer profile (41k nodes of real app work, 60k samples). The analysis then ran on a profile with nothing in it.This change ranks profiles by the number of samples that are not
(idle), so the thread that actually did work gets analyzed.Tests
Profile/ProfileChunkgroups.(idle)/(program)..cpuprofileand a Hermes trace and verify that both still analyze the same as before.npm test, typecheck and lint pass🤖 Generated with Claude Code