Skip to content

Conversation

@dprevost-LMI
Copy link
Contributor

@dprevost-LMI dprevost-LMI commented Oct 25, 2025

Have tsc and linting commands more self-discoverable

  • Add script to run easier tsc and linting commands
  • Test command was not added since there is no test to run
  • Add a command to run all of them in one shot
  • Run prettier with --write to fix every existing warning

Inspired by the CONTRIBUTING.md

Note: I can revert prettier/code changes if we do not want that now!

@vercel
Copy link

vercel bot commented Oct 25, 2025

@dprevost-LMI is attempting to deploy a commit to the Callstack Team on Vercel.

A member of the Team first needs to authorize it.

@dprevost-LMI dprevost-LMI marked this pull request as ready for review October 25, 2025 12:14
@V3RON
Copy link
Contributor

V3RON commented Oct 28, 2025

The GitHub UI is crashing because of the number of changes included 🙈
Just to confirm - aside from reformatting the entire source code, the only thing you added was aliases for running commands in all packages, right?

@dprevost-LMI
Copy link
Contributor Author

dprevost-LMI commented Oct 28, 2025

Yes, beside the below:

  • I added those scripts in package.json
    "tsc": "pnpm nx run-many -t typecheck --projects='packages/*'",
    "eslint": "pnpm nx run-many -t lint --projects='packages/*'",
    "prettier": "prettier --check .",
    "check": "pnpm tsc && pnpm eslint && pnpm prettier"
  • Update prettier to 3.6.2 from the with import syntax
  • Bump pnpm from 9.15.3 to 10.19.0 ( I can revert this one if required)

@V3RON
Copy link
Contributor

V3RON commented Oct 28, 2025

Let's name the aliases after the commands they run - typecheck and lint. For Prettier, let's use format instead (it doesn't necessarily have to be Prettier every time).

@dprevost-LMI dprevost-LMI force-pushed the ease-tsc-linting-commands-and-fix-existing-prettier-warning branch from 2df2d12 to c66248e Compare October 28, 2025 21:48
@dprevost-LMI
Copy link
Contributor Author

dprevost-LMI commented Oct 28, 2025

Here you go:

  "scripts": {
    "prepare": "husky",
    "typecheck": "pnpm nx run-many -t typecheck --projects='packages/*'",
    "lint": "pnpm nx run-many -t lint --projects='packages/*'",
    "format": "prettier --check .",
    "format:fix": "prettier --check . --write",
    "check": "pnpm typecheck && pnpm lint && pnpm format"
  },

@V3RON V3RON self-requested a review October 29, 2025 07:10
- Add script to run easier tsc and linting commands
- Test command was not added since there is not test to run
- Add a command running all of them in one shoot
- Run prettier with --write to fix every existing warning
@dprevost-LMI dprevost-LMI force-pushed the ease-tsc-linting-commands-and-fix-existing-prettier-warning branch from c66248e to 538093e Compare October 30, 2025 10:33
@dprevost-LMI
Copy link
Contributor Author

Rebased and prettier --fix rerun, so ready again!

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants