- 
                Notifications
    You must be signed in to change notification settings 
- Fork 19
chore: Ease tsc linting commands and fix existing prettier warning #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| @dprevost-LMI is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. | 
| The GitHub UI is crashing because of the number of changes included 🙈 | 
| Yes, beside the below: 
 
 | 
| Let's name the aliases after the commands they run - typecheck and lint. For Prettier, let's use format instead (it doesn't necessarily have to be Prettier every time). | 
2df2d12    to
    c66248e      
    Compare
  
    | Here you go:   "scripts": {
    "prepare": "husky",
    "typecheck": "pnpm nx run-many -t typecheck --projects='packages/*'",
    "lint": "pnpm nx run-many -t lint --projects='packages/*'",
    "format": "prettier --check .",
    "format:fix": "prettier --check . --write",
    "check": "pnpm typecheck && pnpm lint && pnpm format"
  }, | 
- Add script to run easier tsc and linting commands - Test command was not added since there is not test to run - Add a command running all of them in one shoot - Run prettier with --write to fix every existing warning
chore: fix regression
c66248e    to
    538093e      
    Compare
  
    | Rebased and prettier --fix rerun, so ready again! | 
Have tsc and linting commands more self-discoverable
Inspired by the CONTRIBUTING.md
Note: I can revert prettier/code changes if we do not want that now!