-
Notifications
You must be signed in to change notification settings - Fork 40
feat: add ccache support in clean command
#620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ccache support in clean command
#620
Conversation
|
@mateuuszzzzz is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
adhorodyski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one change requested on the which command, other that that one NIT. Thanks for shipping this!
|
@cursoragent add changeset with patch version bump, use PR title |
|
Please finish setting up background agents. Go to Cursor |
|
@cursoragent try again |
|
@mateuuszzzzz can I ask you to please add a changeset for this? It's clear AI won't replace us just yet 😅 |
Summary
ccacheto the list of cleanup tasksisCCacheInstalled()to check if ccache is available usingwhich ccachecreateCleanupTasks()to async to support spawn-based availability checksTest plan
When ccache is installed:
npx rock clean[C/C++] CCache compiler cacheappears in the cleanup optionsccache --clearsuccessfullyWhen ccache is NOT installed:
npx rock cleanYou can easily test both scenarios using:
cc: @adhorodyski
Note
Adds a conditional
ccachecleanup task and makes task creation async to detect availability.cleanpluginccachecleanup task (ccache --clear), enabled only when available viaisCCacheInstalled(which ccache).createCleanupTasksasync and updatecleanProjectto await it.CLEANUP_TASK_NAMESwithccache.rockandcreate-rock.Written by Cursor Bugbot for commit 235188b. This will update automatically on new commits. Configure here.