fix: missing -sdk for getting build settings; running incompatible destinations #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
thymikee
force-pushed
the
fix/sdk-destination-device
branch
from
90e3a3d to
065e5cd
Compare
thymikee
commented
Jun 2, 2025
| const artifactName = await formatArtifactName({ | ||
| platform: 'ios', | ||
| traits: [ | ||
| args.destination?.[0] ?? 'simulator', |
Contributor
Author
There was a problem hiding this comment.
this was bug producing e.g. ios-generic/platform=iOS-Debug-{hash}, which would never resolve correctly for a remote artifact. cc @mdjastrzebski
Comment on lines
102
to
106
| args: { | ||
| destination: [getGenericDestination(platformName, 'simulator')], | ||
| ...args, | ||
| }, | ||
| args, | ||
| destination: 'simulator', |
Contributor
Author
There was a problem hiding this comment.
@mdjastrzebski instead of manipulating args, I'm passing the destination as a 'simulator' | 'device' here and further resolve the genericDestination and sdk from that
Comment on lines
+152
to
+161
| if (device.type !== deviceOrSimulator) { | ||
| throw new RnefError( | ||
| `Selected device "${device.name}" is not a ${deviceOrSimulator}. | ||
| Please select available ${deviceOrSimulator} device: | ||
| ${devices | ||
| .filter(({ type }) => type === deviceOrSimulator) | ||
| .map(({ name }) => `• ${name}`) | ||
| .join('\n')}` | ||
| ); | ||
| } |
Comment on lines
194
to
218
| function getSimulatorPlatformSDK(platform: ApplePlatform): PlatformSDK { | ||
| switch (platform) { | ||
| case 'ios': | ||
| return 'iphonesimulator'; | ||
| case 'macos': | ||
| return 'macosx'; | ||
| case 'tvos': | ||
| return 'appletvsimulator'; | ||
| case 'visionos': | ||
| return 'xrsimulator'; | ||
| } | ||
| } | ||
|
|
||
| function getDevicePlatformSDK(platform: ApplePlatform): PlatformSDK { | ||
| switch (platform) { | ||
| case 'ios': | ||
| return 'iphoneos'; | ||
| case 'macos': | ||
| return 'macosx'; | ||
| case 'tvos': | ||
| return 'appletvos'; | ||
| case 'visionos': | ||
| return 'xr'; | ||
| } | ||
| } |
troZee
approved these changes
Jun 3, 2025
| reactNativePath: string; | ||
| artifactName: string; | ||
| binaryPath?: string; | ||
| destination: 'simulator' | 'device'; |
Collaborator
There was a problem hiding this comment.
typedef DestinationType = simu | device
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's necessary to pass
-sdkalongside singular-destinationso that older Xcode versions can resolve the platform name properly. Otherwise it would useiphoneosinstead ofiphonesimulatorand make the resulting app path incorrect.Fixes #371
On top of that this PR improves the way running on iOS is handled when selecting
--destination:simulator, we calculate artifact name with simulator traits and only try to run on simulatorsdevice, we calculate artifact name with device traits and only try to run on devicesTest plan