Skip to content

feat: integrate react-native-brownfield #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thymikee merged 23 commits into from
Jun 18, 2025
Merged

feat: integrate react-native-brownfield #271

thymikee merged 23 commits into from
Jun 18, 2025

Conversation

@atlj
Copy link
Contributor

@atlj atlj commented Apr 22, 2025 •
edited by thymikee
Loading

Summary

This integrates react-native-brownfield to the brownfield template for iOS.

Test plan

  1. Follow the regular development docs and publish all npm packages locally using Verdaccio
  2. Create a new app
  3. Make sure to pick the brownfield plugin
  4. Go to the generated app and call the package:ios script.
  5. Make sure an xcframework file is generated, test the file on a native ios app.

@vercel
Copy link

vercel bot commented Apr 22, 2025

@atlj is attempting to deploy a commit to the Callstack team on Vercel, but is not a member of this team. To resolve this issue, you can:

  • Make your repository public. Collaboration is free for open source and public repositories.
  • Add @atlj as a member. A Pro subscription is required to access Vercel's collaborative features.
    • If you're the owner of the team, click here and add @atlj as a member.
    • If you're the user who initiated this build request, click here to request access.
    • If you're already a member of the Callstack team, make sure that your Vercel account is connected to your GitHub account.

To read more about collaboration on Vercel, click here.

thymikee
thymikee reviewed Apr 23, 2025
View reviewed changes
@atlj atlj force-pushed the rn-brownfield-integration branch from ca40d5f to f1210ae Compare May 9, 2025 12:50
@vercel
Copy link

vercel bot commented May 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rnef ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2025 11:28am

mdjastrzebski
mdjastrzebski reviewed May 20, 2025
View reviewed changes
packages/create-app/src/lib/templates.ts
export const PLUGINS: TemplateInfo[] = [
{
type: 'npm',
name: 'brownfield-ios',
Copy link
Collaborator

@mdjastrzebski mdjastrzebski May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should have unified browfield (iOS + Android) template?

Copy link
Contributor

@thymikee thymikee Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have both specified as optional plugins, that's it

mdjastrzebski
mdjastrzebski reviewed May 20, 2025
View reviewed changes
packages/plugin-brownfield-ios/template/ios/Podfile Outdated
installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
config.build_settings['BUILD_LIBRARY_FOR_DISTRIBUTION'] = 'YES'
config.build_settings['SKIP_INSTALL'] = 'NO'
Copy link
Collaborator

@mdjastrzebski mdjastrzebski May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about other flags from https://www.rnef.dev/docs/brownfield/ios ?

Copy link
Contributor Author

@atlj atlj Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried removing this code block, and it looks like it's working well. Not sure what this exactly solved but removing it as a whole for now.

cc: @okwasniewski

Copy link
Contributor

@okwasniewski okwasniewski Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to solve the need to build ReactBrownfield.xcframework (the library) separately. So as it turned out it's not needed if we package it separately.

@atlj atlj force-pushed the rn-brownfield-integration branch from 7fd9745 to f40153a Compare May 30, 2025 09:35
@okwasniewski
Copy link
Contributor

okwasniewski commented May 31, 2025

I tried it but it unfortunately didn't work, can you do a rebase? 🙏

Something was wrong with linking the plugin (not with the implementation of brownfield itself)

@atlj atlj mentioned this pull request Jun 2, 2025
Closed
@thymikee thymikee force-pushed the rn-brownfield-integration branch 2 times, most recently from 4f58305 to ac2b0ae Compare June 3, 2025 14:30
@atlj atlj force-pushed the rn-brownfield-integration branch 2 times, most recently from 8fb0c6e to db85dea Compare June 14, 2025 22:45
@atlj atlj force-pushed the rn-brownfield-integration branch from d4a5b49 to 7655fcb Compare June 14, 2025 23:41
@atlj atlj changed the title WIP: Rn brownfield integration [WIP] feat: integrate react-native-brownfield Jun 14, 2025
thymikee
thymikee reviewed Jun 16, 2025
View reviewed changes
packages/plugin-brownfield-ios/src/lib/copyHermes.ts Outdated
Comment on lines 34 to 36
path.join(
destinationDir, 'hermes.xcframework'
),
Copy link
Contributor

@thymikee thymikee Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
path.join(
destinationDir, 'hermes.xcframework'
),
hermesDestination,

thymikee
thymikee reviewed Jun 16, 2025
View reviewed changes
thymikee
thymikee reviewed Jun 16, 2025
View reviewed changes
thymikee
thymikee reviewed Jun 16, 2025
View reviewed changes
thymikee
thymikee reviewed Jun 16, 2025
View reviewed changes
@thymikee thymikee force-pushed the rn-brownfield-integration branch from 5d3c9d6 to 51f24b6 Compare June 16, 2025 14:37
@thymikee thymikee mentioned this pull request Jun 16, 2025
Closed
atlj and others added 20 commits June 18, 2025 10:39
@thymikee thymikee force-pushed the rn-brownfield-integration branch from d1bdb32 to 0d23f24 Compare June 18, 2025 08:39
@thymikee thymikee changed the title [WIP] feat: integrate react-native-brownfield feat: integrate react-native-brownfield Jun 18, 2025
@thymikee thymikee merged commit 6acb2db into main Jun 18, 2025
5 checks passed
@thymikee thymikee deleted the rn-brownfield-integration branch June 18, 2025 14:56
@thymikee thymikee mentioned this pull request Aug 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thymikee thymikee thymikee left review comments

@mdjastrzebski mdjastrzebski mdjastrzebski left review comments

@okwasniewski okwasniewski okwasniewski left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@atlj @okwasniewski @thymikee @mdjastrzebski