Filter CMake targets by target name when passed #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
Apple 🍎
kraenhansen
force-pushed
the
kh/filter-by-target-name
branch
from
d5aaa3d to
8cdb205
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
There was a problem hiding this comment.
Pull Request Overview
This PR enables filtering CMake build targets by name in addition to type, allowing callers to select specific shared libraries when multiple are built in a project.
Key changes:
- Added
targetparameter topostBuildfunctions for both Apple and Android platforms - Updated target filtering logic to include target name matching when target names are provided
- Added changeset documenting this patch
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/cmake-rn/src/platforms/apple.ts | Added target name filtering to Apple platform's postBuild function |
| packages/cmake-rn/src/platforms/android.ts | Added target name filtering to Android platform's postBuild function |
| .changeset/cold-showers-arrive.md | Added changeset entry for this patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of simply filtering by shared libraries, we should filter by the
--targetvalue passed tocmake-rnto allow callers to pick the right shared object in CMake projects building outputting multiple.Merging this PR will:
postBuildfunctions.