Skip to content

fix: cargo build release flag #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 25, 2025
Merged

fix: cargo build release flag #203

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9a23358
add changes
dougg0k Jul 24, 2025
26b8f60
removed empty str from arr
dougg0k Jul 24, 2025
5a2fb71
attempt to fix cargo build
dougg0k Jul 24, 2025
d15208f
removed unused file
dougg0k Jul 24, 2025
29d8021
added suggested simplification
dougg0k Jul 24, 2025
58ad23d
removed ci cargo install
dougg0k Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cyan-sloths-move.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"ferric-cli": patch
---

Fixed cargo build release flag
5 changes: 3 additions & 2 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
with:
node-version: lts/jod
- name: Set up JDK 17
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: "17"
distribution: "temurin"
Expand All @@ -51,6 +51,7 @@ jobs:
with:
packages: tools platform-tools ndk;${{ env.NDK_VERSION }}
- run: rustup target add x86_64-linux-android aarch64-linux-android armv7-linux-androideabi i686-linux-android aarch64-apple-ios-sim
- run: cargo install cargo-ndk
- run: npm ci
- run: npm run bootstrap
- run: npm test
Expand Down Expand Up @@ -95,7 +96,7 @@ jobs:
with:
node-version: lts/jod
- name: Set up JDK 17
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: "17"
distribution: "temurin"
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/ferric-example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"bootstrap": "npm run build"
},
"devDependencies": {
"ferric-cli": "^0.2.0"
"ferric-cli": "*"
}
}
6 changes: 4 additions & 2 deletions packages/ferric/src/cargo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ type BuildOptions = {

export async function build(options: BuildOptions) {
const { target, configuration } = options;
await spawn("cargo", ["build", "--target", target], {
const modeConfig = configuration.toLowerCase() === "release" ? "--release" : "";
const cargoBuildArgs = ["build", "--target", target, modeConfig].filter(item => String(item).length > 0)
await spawn("cargo", cargoBuildArgs, {
outputMode: "buffered",
env: {
...process.env,
Expand All @@ -87,7 +89,7 @@ export async function build(options: BuildOptions) {
process.cwd(),
"target",
target,
configuration
modeConfig
);
const dynamicLibraryFile = fs
.readdirSync(targetOutputPath)
Expand Down
Loading