Eliminate npm install noise #137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ARN noise with some local overrides. Unit tests still pass.
|
|
Won't this potentially mess with React Native internals it they actually break across major version upgrades? Our current tests aren't actually exercising React Native. If we really want this, it should be after #133 to ensure the app isn't affected by this. |
kraenhansen
force-pushed
the
main
branch
4 times, most recently
from
90dd405 to
8dac805
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like upstream RN has some intrinsic noise that hasn't been cleaned up in a while, but we can make our corner of the OSS univerise a little tidier.
Eliminate
npm auditand depcrecated package WARN noise on first npm install.Tested on Windows 11,
npm testpasses.