refactor(rfc): options args order #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjastrzebski
force-pushed
the
refactor/options-args-order
branch
from
78aa3d3 to
53fb00a
Compare
jaworek
reviewed
Jan 2, 2024
| ); | ||
|
|
||
| const regex = buildRegex([ | ||
| startOfString, // |
There was a problem hiding this comment.
Unused comment?
Suggested change
| startOfString, // | |
| startOfString, |
There was a problem hiding this comment.
No, inserting comment this way prevents prettier from collapsing complex expression into single line. Multiline expressions are imo more readable.
jaworek
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modify existing function signatures (
buildRegex,repeat) to move options argument to last position. My goal here is to have consistency with optionaloptions, which typically are passed as last argument in JS.In the near future that should also include
capture([...], { name: '...' })variant, wherenamewould be optional.Test plan
Update all tests and docs.