fix: button background edge case #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in non-hovered state
artus9033
force-pushed
the
fix/button-background-edge-case
branch
from
6e0b65b to
6cdd811
Compare
jbroma
approved these changes
Jul 18, 2025
Member
|
Thanks! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an edge case with (likely) subpixel rendering rounding issue in specific layouts, likely due to odd widths of the
Buttoncomponent. In such cases, the component in non-focused state would be displayed with the background purple color remaining in the view box of the button by 1px from the left:The workaround is to extend the left rectangle's width by an extra margin of 1px.
Thanks to @thymikee for suggesting the idea for this workaround!
Test plan
Test the RN Legal docs, where the "CLI" button used to suffer from this issue.