Repository navigation
Conversation
getSwcLoaderOptions tied jsc.transform.react.development to the JSX runtime, so development builds with the default automatic runtime emitted `jsx` instead of `jsxDEV` and lost __source/__self, accurate component stacks and "open in editor", while classic production builds kept them. Config helpers don't know the mode, so RepackPlugin now sets `development` from `mode` for every builtin:swc-loader rule that doesn't set it explicitly. getSwcLoaderOptions and getJsTransformRules accept a `development` option to override it. Part of callstack#1422
Development builds now import `<importSource>/jsx-dev-runtime`; document the `development: false` override for import sources without it and that the mode-based default comes from RepackPlugin. Part of callstack#1422
🦋 Changeset detectedLatest commit: 6266878 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@whydidoo is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1422.
Summary
getSwcLoaderOptions(used bygetJsTransformRules) setjsc.transform.react.developmentfrom the JSX runtime instead of the build mode. As a result:automaticruntime emittedjsxinstead ofjsxDEV, so they had no__source/__self, accurate component stacks or "open in editor";classicproduction builds kept the dev transforms.developmentoption ongetSwcLoaderOptionsandgetJsTransformRules({ swc: { development } }).<importSource>/jsx-dev-runtime. If a customimportSourcedoesn't ship it, setswc: { development: false }.Test plan
tests/integration/src/plugins/RepackPlugin.test.ts(Rspack): withgetJsTransformRules()+RepackPlugin, development mode givestrue, production givesfalse, and an explicitdevelopment: falseis kept. These were red before the change.