fix: add RN polyfills as runtime modules for correct execution order#1340
Merged
fix: add RN polyfills as runtime modules for correct execution order#1340
Conversation
…execution order Polyfills are now added as runtime modules instead of entry modules. This ensures they execute before the webpack startup function, which means they run before Module Federation v2 embed_federation_runtime wrapper. Runtime modules execute during webpack runtime initialization, before __webpack_require__.x() (the startup function) is called. This guarantees polyfills run before any MF v2 federation runtime code. Changes: - Move NativeEntryPlugin to its own folder - Add PolyfillsRuntimeModule that inlines polyfill code - Use additionalTreeRuntimeRequirements hook to add polyfills - Add comprehensive tests with MF v2 integration Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 9f8a6f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
needs more tests being added:
|
jbroma
changed the title
jbroma
changed the title
… add integration tests Polyfills are now added as entry modules (processed by loaders) and referenced by module ID from the runtime module via __webpack_require__, fixing Flow-typed polyfills like error-guard.js being inlined as raw source. The runtime module guards against chunks that don't contain polyfill modules (e.g. MF container chunks). Migrates NativeEntryPlugin tests from Jest unit tests (rspack-only) to vitest integration tests covering both bundlers (webpack/rspack) and all federation variants (none, MF v1, MF v2) with explicit execution order assertions verified against real bundle output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…1.0) Parameterize MF v2 tests across three @module-federation/enhanced versions to verify polyfill execution order is maintained. All three versions run with rspack; webpack tests only run the base version due to serializer registration conflicts when loading multiple MF versions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace machine-specific absolute paths with <rootDir> placeholder for deterministic snapshots across different development environments. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
embed_federation_runtimewrapper__webpack_require__.x()is calledChanges
NativeEntryPluginto its own folderPolyfillsRuntimeModulethat inlines polyfill code directly into the webpack runtimeadditionalTreeRuntimeRequirementshook to add polyfills as runtime modulesExecution Order
With this change, the execution order is now:
embed_federation_runtimewrapper)prevStartup())Related Issues
This could potentially close:
Test Plan
🤖 Generated with Claude Code