Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: initialize React Devtools before React Refresh #1

Merged
merged 1 commit into from
Mar 17, 2021
Merged

fix: initialize React Devtools before React Refresh #1

merged 1 commit into from
Mar 17, 2021

Conversation

zamotany
Copy link
Contributor

Summary

Initialize React DevTools (as part of InitializeCore.js) before initializing React Refresh to avoid the issue listed here: facebook/react#20377.

Test plan

  1. Run application
  2. Open Flipper
  3. Check React DevTools - it should show React component tree
  4. Make more change in source code, the app should apply the update and component tree inside React DevTools should be updated.

@zamotany zamotany merged commit 9e708f8 into main Mar 17, 2021
@zamotany zamotany deleted the fix/init-devtools-before-react-refresh branch March 17, 2021 13:53
@woodrufs woodrufs mentioned this pull request Apr 1, 2021
Closed
@arelian11 arelian11 mentioned this pull request Dec 2, 2022
Closed
@vlak-koder vlak-koder mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zamotany