Skip to content

Commit

Permalink
Revert debugger launch behaviour to default profile (facebook#44638)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#44638

Reverts the debugger launch flow to use the default `ChromeLauncher` profile. This is the approach used in the current `--experimental-debugger` experiment and by Expo.

This is motivated after a review of the tradeoffs of a guest profile — which allow us to programatically quit the browser process, however takes over system URL handling.

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D57619542

fbshipit-source-id: 3713e1cf8eed61e7a70ed1e4eb58f02da845155f
  • Loading branch information
huntie authored and facebook-github-bot committed May 27, 2024
1 parent a908387 commit 7e0f86f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions packages/dev-middleware/src/utils/DefaultBrowserLauncher.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ const DefaultBrowserLauncher: BrowserLauncher = {
`react-native-debugger-frontend-${browserType}`,
);
const launchedChrome = await ChromeLauncher.launch({
ignoreDefaultFlags: true,
chromeFlags: [
...ChromeLauncher.Launcher.defaultFlags().filter(
/**
Expand All @@ -64,10 +65,8 @@ const DefaultBrowserLauncher: BrowserLauncher = {
`--app=${url}`,
`--user-data-dir=${userDataDir}`,
'--window-size=1200,600',
'--guest',
],
chromePath,
ignoreDefaultFlags: true,
});

return {
Expand Down

0 comments on commit 7e0f86f

Please sign in to comment.