Repository navigation
feat: modern event subsystem - #1944
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next/event-system #1944 +/- ##
=====================================================
+ Coverage 98.56% 98.70% +0.13%
=====================================================
Files 87 95 +8
Lines 1744 2080 +336
Branches 459 550 +91
=====================================================
+ Hits 1719 2053 +334
- Misses 24 26 +2
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| if (isObject(sourceValue) && isObject(targetValue)) { | ||
| mergeInto(targetValue, sourceValue); | ||
| } else { | ||
| target[key] = sourceValue; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an experimental modern event system that follows React Native's own dispatch (capture and bubble phases, direct events). Turn it on with
configure({ unstable_eventSystem: 'modern' }). The default stays'legacy'.src/events/legacy/and adds the new one insrc/events/modern/.fireEventanduserEventchoose the system on each call.fireEvent.pressstays legacy for now.Test plan
yarn test:ci,yarn typecheck,yarn lintandyarn format:checkpass in both systems. I haven't run it locally against older React Native versions.