Skip to content

fix: scroll to event seq - #1943

Merged
mdjastrzebski merged 5 commits into
mainfrom
fix/scroll-to-event-seq
Oct 8, 2026
Merged

mdjastrzebski merged 5 commits into
mainfrom
fix/scroll-to-event-seq

Conversation

@mdjastrzebski

@mdjastrzebski mdjastrzebski commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Summary

user.scrollTo() skipped the scroll event for the last drag step, unlike native ScrollView. Because FlatList reads its offset from onScroll, it ended up at 75% of the target, which threw off onEndReached and windowing.

  • Drag now emits scroll for every step, including the last.
  • A scroll that doesn't move emits no scroll for drag or momentum.
  • Updated the comments and the 14.x docs.

Test plan

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.56%. Comparing base (7e25db3) to head (76d9742).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1943   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files          87       87           
  Lines        1744     1744           
  Branches      474      473    -1     
=======================================
  Hits         1719     1719           
  Misses         24       24           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mdjastrzebski
mdjastrzebski merged commit 5a8f4a7 into main Oct 8, 2026
40 checks passed
@mdjastrzebski
mdjastrzebski deleted the fix/scroll-to-event-seq branch October 8, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant