chore: revamp the cookbook app #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… management recipes dir
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1635 +/- ##
==========================================
- Coverage 95.51% 95.41% -0.11%
==========================================
Files 99 100 +1
Lines 5400 5433 +33
Branches 857 865 +8
==========================================
+ Hits 5158 5184 +26
- Misses 242 249 +7 ☔ View full report in Codecov by Sentry. |
|
How are you @mdjastrzebski? Could you, please, have a look at this PR? |
mdjastrzebski
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
@vanGalilea just wow! I'm impressed with your work. This makes the app look so much nicer.
mdjastrzebski
pushed a commit
that referenced
this pull request
Jul 16, 2024
* create a Jotai examples dir in cookbook with related utils, add state management recipes dir * add docs with examples * extract state from component to state, utils, simplify types and custom render func. * refactor: tweaks & cleanup * make cookbook app runnable * update yarn.lock file * fix TS issue and spelling * remove duplicate files and adjust testMatch in config to ensure no utils test run --------- Co-authored-by: stevegalili <steve.galili@mywheels.nl> refactor: tweak cookbook (#1636) * refactor: move files around * refactor: simplify * chore: remove custom fonts * chore: tweak eslint * chore: update yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Cookbook app previously couldn't be run locally, and its recipes weren't easily accessible. To address this, I made the following updates:
@expo/metro-runtimelibrary to enable local app execution.Test Plan
To test these changes, follow these steps:
cd examples/ yarn yarn startVisuals
To get a sense of the updated look and feel of the app, check out this screen recording.