- 
                Notifications
    You must be signed in to change notification settings 
- Fork 276
feat: check accessibilityLabelledBy in *ByLabelText queries #1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check accessibilityLabelledBy in *ByLabelText queries #1191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @pafry7. The code looks pretty solid. I've left some comments regarding code organisation and docs.
0403f18    to
    ecc4418      
    Compare
  
    | I've added  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pafry7 Looks pretty solid. I've added some suggestions for improvements to code and tests. Also pls rebased due to some other recent changes.
ecc4418    to
    52f3538      
    Compare
  
    | Let's pause this waiting for #1222, as it has some overlapping changes, which might be useful in this PR. | 
52f3538    to
    8f6bc5f      
    Compare
  
    | Rebased to current  | 
aef1fb0    to
    978865a      
    Compare
  
    | Rebased to  @AugustinLF could you take another look at this PR? | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
4502cf2    to
    7e9c551      
    Compare
  
    9f90370    to
    9303a79      
    Compare
  
    d4f72be    to
    21acc57      
    Compare
  
    | Codecov ReportBase: 95.13% // Head: 95.19% // Increases project coverage by  
 
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #1191      +/-   ##
==========================================
+ Coverage   95.13%   95.19%   +0.06%     
==========================================
  Files          46       47       +1     
  Lines        3205     3249      +44     
  Branches      483      489       +6     
==========================================
+ Hits         3049     3093      +44     
  Misses        156      156              
 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. | 
Summary
Adds support for accessibilityLabelledBy in
*ByLabelTextqueries as in #1183.