Use ImageURISource for thumb image instead of ImageSource to fix image not loading
#714
+6,988
−9,993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+226
to
+230
| img->size.width = newScreenProps.thumbImage.width; | ||
| img->size.height = newScreenProps.thumbImage.height; | ||
| img->scale = newScreenProps.thumbImage.scale; | ||
| img->bundle = newScreenProps.thumbImage.bundle; | ||
| img->uri = newScreenProps.thumbImage.uri; |
There was a problem hiding this comment.
I guess now codegen treats our ImageSource as a custom type so it generates an intermediate representation of it. I wonder if there is a built-in way to handle it 🤔
But it looks good as a fix for now
|
Looking forward to merging into main line release soon, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #711
It migrates from
ImageSourcetype from RN toImageURISource. Those are both from RN and have common props howeverImageSourceis no longer supported by the v0.79 app (and beyond).This fix includes both iOS and Android.
Also, all dev deps were updated to make sure we have the recent types used within the package when consumed by the app.
Note:: Removing tests from workflow is temporary due to versions update and tests now failing (some features of React test were used previously).