-
Notifications
You must be signed in to change notification settings - Fork 282
Release: v5.0.0 - new architecture only #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a86e3d7
to
7da35d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess only thing is that maybe those dependencies should also be updated - like react from 18 to 19 and so on ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of them we have in devDependencies, it's up to us what version we use to create a lib, as long as it cooperates nicely with what user has as deps in their app.
We could update those, but I'd rather leave it for the further releases if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine,
This pull request releases Slider to version 5.0.0 with new architecture only.