fix: Searchbar TS #943
Merged
fix: Searchbar TS #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gawrysiak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API. |
Trancever
reviewed
Mar 21, 2019
| export declare class Searchbar extends React.Component<SearchbarProps> {} | ||
| export declare class Searchbar extends React.Component<SearchbarProps> { | ||
| isFocused: () => boolean; | ||
| clear: () => void; |
There was a problem hiding this comment.
Why is type for clear and focus different? Can't w unify it?
There was a problem hiding this comment.
yeah, you're right, it was copied from TextInput, so sent a fix for TextInput as well now
Trancever
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing TS typings for Searchbar methods