fix: Add SafeAreaView to FAB Group #831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FAB Group currently doesn't support SafeAreaView. It results in an inconsistent behavior between different phones when using a bottom navigation or such.
Since SafeAreaView is already there for components like Snackbar or BottomNavigation, it might be a good idea to add it here as well.
It's also not so obvious to handle it per project cause of the dark overlay that breaks when SafeAreaView applied outside the component. For now I've ended up using react-native-iphone-x-helper package for my local projects to apply different padding values when notch is there, so hopefully the PR provides a better solution.
Before:
After: