fix: fix error on width change of AnimatedFAB when label is empty string #4729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onTextLayout
sets the width of the text for theAnimatedFAB
when the text changes. If thelabel
is an empty string thenativeEvent.lines[0]
is undefined for iOS. This change handles this case and defaults to0
.Motivation
On iOS, when the
label
is changed from a non-empty string to and empty string, it throws an Uncaught errorCannot read property 'width' of undefined
Related issue
None
Test plan
Tested on iPhone 11 by changing the
label
from a non-empty string to an empty string. Before the fix, this would throw an Uncaught error. After the fix, not error was thrown and the component resized as expected.