fix(text-input): very long input label truncated when scaled #4414
+1,080
−814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @seb-zabielski, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
gedu
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The label in the TextInput component (both flat and outlined) is truncated when it is longer than the available width. This is expected behaviour, but the issue occurs when the label is moved over an input (focus on input or input with a value). The entire label is scaled, which causes the label to continue to be truncated even though we have space to show the rest of the content.
Goal
Increase maximum text width to the maximum possible space.
Related issue
#4350
Test plan
Use TextInput with very long label. You can use example app