chore: Ignore the __tests__ directory when publishing to npm #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gawrysiak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
Thank you for the PR! |
eriveltonelias
pushed a commit
to eriveltonelias/react-native-paper
that referenced
this pull request
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the tests directory when publishing to npm. It wasn't possible to place the .npmignore file in the main directory due to a known npm issue - it seems like the .npmignore entries won't affect directories listed within the package.json "files" list. The workaround was to place the .npmignore file in a subdirectory.
Motivation
Fixes #320.
Test plan
Go to the project dir and run npm pack. You'll get a package and see the files were not included.