Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add surface shadows #3089

Merged
merged 18 commits into from
Mar 25, 2022
Merged

feat: add surface shadows #3089

merged 18 commits into from
Mar 25, 2022

Conversation

Drakeoon
Copy link
Contributor

Summary

This PR aims to add new Material 3 shadows support to the Surface element

Test plan

Run yarn example start

@Drakeoon Drakeoon requested a review from lukewalczak February 15, 2022 11:32
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@Drakeoon Drakeoon force-pushed the feat/add-surface-shadows branch from 19c3212 to f483228 Compare March 3, 2022 22:55
@callstack-bot
Copy link

callstack-bot commented Mar 3, 2022 •
edited
Loading

Hey @Drakeoon, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link

github-actions bot commented Mar 3, 2022

The mobile version of example app from this branch is ready! You can see it here

.

4 similar comments
@github-actions
Copy link

github-actions bot commented Mar 3, 2022

The mobile version of example app from this branch is ready! You can see it here

.

@github-actions
Copy link

github-actions bot commented Mar 3, 2022

The mobile version of example app from this branch is ready! You can see it here

.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@Drakeoon Drakeoon force-pushed the feat/add-surface-shadows branch from ca59f2e to 7e46fb0 Compare March 18, 2022 15:00
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak merged commit d901ee3 into next Mar 25, 2022
@lukewalczak lukewalczak deleted the feat/add-surface-shadows branch March 25, 2022 23:02
lukewalczak pushed a commit that referenced this pull request Jun 8, 2022
@Drakeoon @lukewalczak
feat: add surface shadows (#3089)
e8b7515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukewalczak lukewalczak Awaiting requested review from lukewalczak

Assignees

@lukewalczak lukewalczak

@Drakeoon Drakeoon

Labels
Material You (v5) Surface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Drakeoon @callstack-bot @lukewalczak