Skip to content

feat: add accessibilityLabel to DrawerItem #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trancever merged 1 commit into from
Jan 31, 2020
Merged

feat: add accessibilityLabel to DrawerItem #1622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/components/Drawer/DrawerItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ type Props = {
* Function to execute on press.
*/
onPress?: () => void;
/**
* Accessibility label for the button. This is read by the screen reader when the user taps the button.
*/
accessibilityLabel?: string;
style?: StyleProp<ViewStyle>;
/**
* @optional
Expand All @@ -50,7 +54,16 @@ class DrawerItem extends React.Component<Props> {
static displayName = 'Drawer.Item';

render() {
const { icon, label, active, theme, style, onPress, ...rest } = this.props;
const {
icon,
label,
active,
theme,
style,
onPress,
accessibilityLabel,
...rest
} = this.props;
const { colors, roundness } = theme;
const backgroundColor = active
? color(colors.primary)
Expand Down Expand Up @@ -85,6 +98,7 @@ class DrawerItem extends React.Component<Props> {
accessibilityComponentType="button"
accessibilityRole="button"
accessibilityStates={active ? ['selected'] : []}
accessibilityLabel={accessibilityLabel}
>
<View style={styles.wrapper}>
{icon ? (
Expand Down