-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: add radio button group item to anable pressing the whole row #1468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import * as React from 'react'; | ||
| import { View, StyleSheet } from 'react-native'; | ||
| import { Colors, withTheme, RadioButton, Theme } from 'react-native-paper'; | ||
|
|
||
| type Props = { | ||
| theme: Theme; | ||
| }; | ||
|
|
||
| type State = { | ||
| value: string; | ||
| }; | ||
|
|
||
| class RadioButtonGroupWithItemsExample extends React.Component<Props, State> { | ||
| static title = 'Radio Button Group With Items'; | ||
|
|
||
| state = { | ||
| value: 'first', | ||
| }; | ||
|
|
||
| render() { | ||
| const { | ||
| theme: { | ||
| colors: { background }, | ||
| }, | ||
| } = this.props; | ||
| return ( | ||
| <View | ||
| style={[ | ||
| styles.container, | ||
| { | ||
| backgroundColor: background, | ||
| }, | ||
| ]} | ||
| > | ||
| <RadioButton.Group | ||
| value={this.state.value} | ||
| onValueChange={(value: string) => this.setState({ value })} | ||
| > | ||
| <RadioButton.Item label="First item" value="first" /> | ||
| <RadioButton.Item label="Second item" value="second" /> | ||
| </RadioButton.Group> | ||
| </View> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| const styles = StyleSheet.create({ | ||
| container: { | ||
| flex: 1, | ||
| backgroundColor: Colors.white, | ||
| padding: 8, | ||
| }, | ||
| }); | ||
|
|
||
| export default withTheme(RadioButtonGroupWithItemsExample); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| import * as React from 'react'; | ||
| import { View, Text, StyleSheet, StyleProp, ViewStyle } from 'react-native'; | ||
| import TouchableRipple from './TouchableRipple'; | ||
| import RadioButton from './RadioButton'; | ||
| import { RadioButtonContext, RadioButtonContextType } from './RadioButtonGroup'; | ||
|
|
||
| type Props = { | ||
| /** | ||
| * Value of the radio button. | ||
| */ | ||
| value: string; | ||
| /** | ||
| * Label to be displayed on the item. | ||
| */ | ||
| label: string; | ||
| /** | ||
| * Function to execute on press. | ||
| */ | ||
| onPress?: () => void; | ||
| /** | ||
| * Status of radio button. | ||
| */ | ||
| status?: 'checked' | 'unchecked'; | ||
| /** | ||
| * Additional styles for container View | ||
| */ | ||
| style?: StyleProp<ViewStyle>; | ||
| }; | ||
|
|
||
| /** | ||
| * RadioButton.Item allows you to press the whole row (item) instead of only the RadioButton. | ||
| * | ||
| * ## Usage | ||
| * ```js | ||
| * import * as React from 'react'; | ||
| * import { View } from 'react-native'; | ||
| * import { RadioButton, Text } from 'react-native-paper'; | ||
| * | ||
| * export default class MyComponent extends React.Component { | ||
| * state = { | ||
| * value: 'first', | ||
| * }; | ||
| * | ||
| * render() { | ||
| * return( | ||
| * <RadioButton.Group | ||
| * onValueChange={value => this.setState({ value })} | ||
| * value={this.state.value} | ||
| * > | ||
| * <RadioButton.Item label="First item" value="first" /> | ||
| * <RadioButton.Item label="Second item" value="second" /> | ||
| * </RadioButton.Group> | ||
| * ) | ||
| * } | ||
| * } | ||
| *``` | ||
| */ | ||
| class RadioButtonItem extends React.Component<Props> { | ||
| static displayName = 'RadioButton.Item'; | ||
|
|
||
| isChecked = (context: RadioButtonContextType) => | ||
| context.value === this.props.value ? 'checked' : 'unchecked'; | ||
|
|
||
| handlePress = (context: RadioButtonContextType) => () => { | ||
| const { onPress } = this.props; | ||
| const onValueChange = context ? context.onValueChange : () => {}; | ||
|
|
||
| onPress ? onPress() : onValueChange(this.props.value); | ||
| }; | ||
|
|
||
| render() { | ||
| const { value, label, style } = this.props; | ||
|
|
||
| return ( | ||
| <RadioButtonContext.Consumer> | ||
| {context => ( | ||
| <TouchableRipple onPress={this.handlePress(context)}> | ||
| <View style={[styles.container, style]} pointerEvents="none"> | ||
| <Text>{label}</Text> | ||
| <RadioButton | ||
| value={value} | ||
| status={ | ||
| this.props.status || (context && this.isChecked(context)) | ||
| } | ||
| ></RadioButton> | ||
| </View> | ||
| </TouchableRipple> | ||
| )} | ||
| </RadioButtonContext.Consumer> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| export default RadioButtonItem; | ||
|
|
||
| const styles = StyleSheet.create({ | ||
| container: { | ||
| flexDirection: 'row', | ||
| alignItems: 'center', | ||
| justifyContent: 'space-between', | ||
| paddingVertical: 8, | ||
| paddingHorizontal: 16, | ||
| }, | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to accept
styleprop and pass it to theViewlike that:style={[styles.container, style]}so users can change flex-direction or other properties