Skip to content

fix: fix initial label position when value is set on RN 0.61 #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
satya164 merged 1 commit into from
Oct 31, 2019
Merged

fix: fix initial label position when value is set on RN 0.61 #1441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/TextInput/TextInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,10 @@ class TextInput extends React.Component<TextInputProps, State> {
componentDidUpdate(prevProps: TextInputProps, prevState: State) {
if (
prevState.focused !== this.state.focused ||
prevState.value !== this.state.value
prevState.value !== this.state.value ||
// workaround for animated regression for react native > 0.61
// https://github.com/callstack/react-native-paper/pull/1440
prevState.labelLayout !== this.state.labelLayout
) {
// The label should be minimized if the text input is focused, or has text
// In minimized mode, the label moves up and becomes small
Expand Down