fix: fix text input disappearing value on blur when in uncontrolled mode #1434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mmarkusik, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
I gave this a test and it works for me - and solves my problem using TextInput uncontrolled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request fixes the issue mentioned in Passing TextInput props dynamically hides text input field Value #1346. When TextInput is in uncontrolled mode it's text value disappears when blurred.
Test plan
TextInputExamplecomponentvalueandonChangeTextprops from any text input