Skip to content

Conversation

@NoemiRozpara
Copy link

@NoemiRozpara NoemiRozpara commented Oct 29, 2019

Changes:

  1. Minimizing label and placeholder logic doesn't depend now on error state, just on value and focus of the field
  2. Label has new prop errorColor and uses it if the field has error for the better user experience

Motivation

Fixes #1387

Test plan

ezgif-6-881528d3ff86

@callstack-bot
Copy link

Hey @NoemiRozpara, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@Trancever Trancever requested a review from jbinda October 29, 2019 11:00
Copy link
Contributor

@jbinda jbinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TextInput minimizes label without a value when error is true

4 participants