Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change outline textinput label behaviour #1241

Merged
merged 3 commits into from
Jul 31, 2019

Conversation

jbinda
Copy link
Contributor

@jbinda jbinda commented Jul 24, 2019

PR makes few things:

  1. Refactor outline input label - moves components to separate folder and extract one of the component (LabelBackground)
  2. Fix spacing around label in outline input when control has focus or value
  3. Adjust label background when backgroundColor is passed in styles to the outline input
  4. change input padding from 12 to 14 according to material guidelines inputs

image

Test plan

BEFORE
Note: more white space on right side of the label and gray background outside the outline border

Screenshot 2019-07-24 at 15 57 41

Screenshot 2019-07-24 at 15 57 47

AFTER
Note: Equal margin of 4px on both sides of the minimized label, correct spacing and border cutoff view sized properly

image

image

@jbinda jbinda requested a review from Trancever July 24, 2019 14:17
@jbinda jbinda changed the title refactor: change outline background behaviour refactor: change outline textinput label behaviour Jul 24, 2019
@callstack-bot
Copy link

callstack-bot commented Jul 24, 2019

Hey @jbinda, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@jbinda jbinda requested a review from Trancever July 31, 2019 08:25
@Trancever Trancever merged commit 3839cfa into callstack:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants