Skip to content

fix(android): prevent taps while scrolling #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
troZee merged 2 commits into from
Jan 20, 2025
Merged

fix(android): prevent taps while scrolling #961

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2489094
fix(android): prevent taps while scrolling
gpp-0 Jan 16, 2025
3309fb7
fix: add notifyNativeGestureEnded
gpp-0 Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions android/src/main/java/com/reactnativepagerview/NestedScrollableHost.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import android.view.ViewConfiguration
import android.widget.FrameLayout
import androidx.viewpager2.widget.ViewPager2
import androidx.viewpager2.widget.ViewPager2.ORIENTATION_HORIZONTAL
import com.facebook.react.uimanager.events.NativeGestureUtil
import kotlin.math.absoluteValue
import kotlin.math.sign

Expand All @@ -27,6 +28,7 @@ class NestedScrollableHost : FrameLayout {
private var touchSlop = 0
private var initialX = 0f
private var initialY = 0f
private var nativeGestureStarted: Boolean = false
private val parentViewPager: ViewPager2?
get() {
var v: View? = parent as? View
Expand Down Expand Up @@ -57,17 +59,14 @@ class NestedScrollableHost : FrameLayout {
}

private fun handleInterceptTouchEvent(e: MotionEvent) {
val orientation = parentViewPager?.orientation ?: return

// Early return if child can't scroll in same direction as parent
if (!canChildScroll(orientation, -1f) && !canChildScroll(orientation, 1f)) {
return
}
val orientation = parentViewPager?.orientation

if (e.action == MotionEvent.ACTION_DOWN) {
initialX = e.x
initialY = e.y
parent.requestDisallowInterceptTouchEvent(true)
if (orientation != null) {
parent.requestDisallowInterceptTouchEvent(true)
}
} else if (e.action == MotionEvent.ACTION_MOVE) {
val dx = e.x - initialX
val dy = e.y - initialY
Expand All @@ -78,6 +77,10 @@ class NestedScrollableHost : FrameLayout {
val scaledDy = dy.absoluteValue * if (isVpHorizontal) 1f else .5f

if (scaledDx > touchSlop || scaledDy > touchSlop) {
NativeGestureUtil.notifyNativeGestureStarted(this, e)
nativeGestureStarted = true

if (orientation == null) return
if (isVpHorizontal == (scaledDy > scaledDx)) {
// Gesture is perpendicular, allow all parents to intercept
parent.requestDisallowInterceptTouchEvent(false)
Expand All @@ -94,4 +97,14 @@ class NestedScrollableHost : FrameLayout {
}
}
}

override fun onTouchEvent(e: MotionEvent): Boolean {
if (e.actionMasked == MotionEvent.ACTION_UP) {
if (nativeGestureStarted) {
NativeGestureUtil.notifyNativeGestureEnded(this, e)
nativeGestureStarted = false
}
}
return super.onTouchEvent(e)
}
}
Loading