-
Notifications
You must be signed in to change notification settings - Fork 215
feat: option to add nitro views #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
58a21d3
ce5ed31
ba232d2
82fdf09
4595d45
f124db5
89da9cb
427ff5b
6e003c8
46c4f89
14496f0
aa67b12
0250938
6ffc282
fa24990
7b88962
e545ba3
1a21f3b
7ebea03
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,13 +18,14 @@ yarn | |
``` | ||
|
||
> Since the project relies on Yarn workspaces, you cannot use [`npm`](https://github.com/npm/cli) for development. | ||
<% if (project.moduleConfig === 'nitro-modules') { -%> | ||
> <% if (project.moduleConfig === 'nitro-modules' || project.viewConfig === 'nitro-view') { -%> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the |
||
|
||
This project uses Nitro Modules. If you're not familiar with how Nitro works, make sure to check the [Nitro Modules Docs](https://nitro.margelo.com/). | ||
|
||
You need to run [Nitrogen](https://nitro.margelo.com/docs/nitrogen) to generate the boilerplate code required for this project. The example app will not build without this step. | ||
|
||
Run **Nitrogen** in following cases: | ||
|
||
- When you make changes to any `*.nitro.ts` files. | ||
- When running the project for the first time (since the generated files are not committed to the repository). | ||
|
||
|
@@ -33,6 +34,7 @@ To invoke **Nitrogen**, use the following command: | |
```sh | ||
yarn nitrogen | ||
``` | ||
|
||
<% } -%> | ||
|
||
Comment on lines
+37
to
39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this will add 2 new lines after processing so we should remove this new line - or add a new line above this block and remove the one after. |
||
The [example app](/example/) demonstrates usage of the library. You need to run it to test any changes you make. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather not have a workaround for old code. we're testing on newer xcode version so this won't be tested properly. Lets remove this.