fix: ios example duplicated symbols due to codegen #757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed #755
There is an effort towards shipping React Native in a prebuilt format on iOS. As a result, some of the codegen-related custom code have to be generated at the build time. However, these changes also affected the codegen generated native code for libraries. This PR patches that behavior on bob level.
Related PRs:
RCTAppDependencyProvider
for apps facebook/react-native#47650Test plan
This adds 3 unit test cases to make sure we're able to parse the codegen paths and delete the necessary files.
To test it locally:
npx create-react-native-library
, and pick turbo modulesyarn link path/to/bob --all
in the new libraryyarn bob build --target codegen
.podspec
file or mm files inandroid/generated
.podspec
file or any of the following files inios/generated
: