fix: duplicate dynamic libs by retaining the instance of the map #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artus9033
approved these changes
Dec 2, 2025
krozniata
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the bug reported by installing the latest reanimated which requires you to also install the worklets package. Since reanimated internally adds worklets as a subproject, it brings in the worklets dynamic (.so) lib with itself. Now, when worklets is compiled separately, we face the duplicate dynamic lib error because worklets.so already exists in the aar.
This was happening because we internally maintain a map to evaluate if a certain dynamic lib is already added to the AAR. However, due to the implementation details that map was being re-instantiated in the loop. The fix is to retain that map to correctly evaluate whether a dynamic lib is added to the AAR or not.
Test plan
Tested locally