Skip to content

Conversation

@okwasniewski
Copy link
Member

@okwasniewski okwasniewski commented Nov 9, 2025

Summary

CleanShot 2025-11-09 at 15 06 41@2x

This PR makes sure circles are now properly rendered every time. Before we didnt invalidate layer when layout metrics changed.

We also now support non uniform borders.

CleanShot 2025-11-09 at 15 20 36@2x

Note

Adds per-corner border radius handling and forces layer invalidation on layout updates to fix circle rendering; updates LiquidGlass pod to 0.5.0.

  • iOS (LiquidGlassView):
    • Support non-uniform borders by computing per-corner radii and applying UICornerConfiguration with individual corner values in ios/LiquidGlassView.mm.
    • Set _needsInvalidateLayer = YES on layout metric changes to reapply corner configuration and fix circle rendering.
  • Dependencies:
    • Bump LiquidGlass pod to 0.5.0 in example/ios/Podfile.lock.

Written by Cursor Bugbot for commit 37bb42c. This will update automatically on new commits. Configure here.

@okwasniewski okwasniewski requested a review from Copilot November 9, 2025 14:07
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements support for individual corner radii in the LiquidGlass component by replacing uniform border radius handling with per-corner configuration. The version has been bumped from 0.4.2 to 0.5.0 to reflect this enhancement.

  • Replaced uniform border radius implementation with individual corner radius support
  • Updated corner configuration to use separate values for each corner (topLeft, topRight, bottomLeft, bottomRight)
  • Added layout invalidation trigger when layout metrics change

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
ios/LiquidGlassView.mm Implements per-corner border radius support by calculating individual corner radii using MAX of horizontal/vertical values and configuring UICornerConfiguration with separate corner radius values
example/ios/Podfile.lock Updates LiquidGlass version from 0.4.2 to 0.5.0 and refreshes dependency checksums

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@okwasniewski okwasniewski force-pushed the feat/non-uniform-border branch from 6f1d965 to 37bb42c Compare November 9, 2025 14:12
@okwasniewski okwasniewski merged commit 64d4dd8 into main Nov 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants