feat: use UICornerConfiguration for borders #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
okwasniewski
force-pushed
the
feat/support-context-menu
branch
from
32017e6 to
cee1564
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements proper border configuration handling for LiquidGlassView using iOS's UICornerConfiguration API to fix animation issues with borders. The implementation now correctly responds to changes in border styles, radii, and colors.
Key changes:
- Added border change detection and layer invalidation mechanism in the iOS native component
- Implemented
finalizeUpdatesmethod to apply border configurations usingUICornerConfiguration(iOS 26.0+) - Enhanced the example app with a new
LiquidToolBarcomponent to demonstrate border animations
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ios/LiquidGlassView.mm | Implements border configuration handling with UICornerConfiguration API and layer invalidation mechanism |
| example/src/App.tsx | Adds new toolbar component with dropdown menus to demonstrate border animation functionality |
| example/package.json | Adds required dependencies for the new dropdown menu components |
| example/ios/LiquidGlassExample.xcodeproj/project.pbxproj | Removes empty inputPaths/outputPaths arrays from CocoaPods build phases |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
okwasniewski
force-pushed
the
feat/support-context-menu
branch
from
cee1564 to
a4fae06
Compare
|
Big thank you @okwasniewski! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses border configuration for borders fixing #22
The animation is now properly applied.
Screen.Recording.2025-10-23.at.14.31.07.mov