-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: documentation website #320
Conversation
9d22bc0
to
cb1d741
Compare
cb1d741
to
7852063
Compare
7852063
to
870d3ce
Compare
@satya164 What is the status of it? Should it be closed or can it be continued? |
I think someone can pick it up and continue |
Can I pick this up since we're adopting Linaria for my team project and have the need to check up documentation constantly but current markdown files are not convenient enough. |
@trongthanh feel free to pick it up. what I had trouble with is to figure out how to add syntax highlighting for CSS literals and didn't have enough time to investigate. lemme know if we need any changes in component-docs to support it. |
I've looked into I guess they only added this template string highlighting recently and after this PR. I've tried it with following patch to the highlight.js file: ...
refractor.register(require('refractor/lang/javascript'));
+ refractor.register(require('refractor/lang/js-extras'));
+ refractor.register(require('refractor/lang/js-templates'));
refractor.register(require('refractor/lang/typescript'));
... The optional package |
@trongthanh awesome! would be cool if you added that in a PR and I'll make a release. |
Before I open a PR, I'd like to clarify my intention regarding renaming of the MD files. So, as per this PR, the markdowns are renamed with order number so that they are deliberately sorted in a file glob pattern. However, with
To avoid renaming current markdown files as well as because component-docs is currently having this CLI pages glob issue, I'd like to suggest that we add The downside is that we have to manually add new entries when there are new MD. |
I'll look at the glob issue, but let's keep the config file since we'd want more organization such as sections (Guides, API Reference etc.). Though would be good to have an array like following and then generate pages array from it: [
'Home.mdx',
'GET_STARTED.md',
...
] |
TODO