Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bad options not returning an error code #156

Merged

Conversation

coordt
Copy link
Member

@coordt coordt commented Mar 16, 2024

Fixes #153

Copy link

Version hint: patch
Current version: 0.19.1
New version (when merged): 0.19.2

Comment ID: Display the version hint-auto-generated

Copy link

github-actions bot commented Mar 16, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-16 16:01 UTC

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.44%. Comparing base (c40e4f9) to head (3b5f1de).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files          24       24           
  Lines        1479     1479           
  Branches      295      295           
=======================================
  Hits         1382     1382           
  Misses         68       68           
  Partials       29       29           
Flag Coverage Δ
python-3.10 93.44% <ø> (ø)
python-3.11 93.44% <ø> (ø)
python-3.8 93.44% <ø> (ø)
python-3.9 93.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coordt coordt merged commit b5a7598 into master Mar 16, 2024
14 checks passed
@coordt coordt deleted the 153-invalid-command-line-arguments-result-in-non-zero-exit-code branch March 16, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing invalid command line arguments does not result in non-zero exit code
1 participant