Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving Issue 116 #117

Merged
merged 8 commits into from
Oct 13, 2021
Merged

Resolving Issue 116 #117

merged 8 commits into from
Oct 13, 2021

Conversation

callahantiff
Copy link
Owner

Purpose

As pointed out in issue #116 an issue with writing out metadata to a flat-file was discovered and the root cause was the presence of \n characters in long strings obtained from the ontologies. The solution was to check all strings before writing them out to ensure that the characters were removed.

Output impacted

  • xxxx__NodeLabels.txt
  • node_metadata_dict.pkl

There is a fix underway to update and fix all archived output to address this error.

@callahantiff callahantiff added the bug Something isn't working label Oct 13, 2021
@callahantiff callahantiff self-assigned this Oct 13, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

93.8% 93.8% Coverage
0.0% 0.0% Duplication

@callahantiff callahantiff merged commit 6560304 into master Oct 13, 2021
@callahantiff callahantiff deleted the issue_116 branch October 13, 2021 08:17
@callahantiff
Copy link
Owner Author

@ChuckKollar - Just wanted to call to your attention this PR, which resulted in some minor changes to the notebooks/OWLNETS_Example_Application.ipynb file. See here for details. I am happy to make a PR to your repos in the future for changes like this if that would be helpful. Just let me know! 😄

@callahantiff
Copy link
Owner Author

Solution for Existing Files: The Gist used to update and fix the node_metadata_dict.pkl and XXXX_NodeLabels.txt files for all v2.0.0 (excluding build_10MAY2020), v2.1.0, and v3.0.0 builds can be found here: https://gist.github.com/callahantiff/f31a936d967c8f44d5d0e51c563ae65f

@callahantiff callahantiff restored the issue_116 branch October 14, 2021 04:39
@callahantiff callahantiff deleted the issue_116 branch October 14, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant