🛡️ Sentinel: [HIGH] Fix sensitive data leakage and newline injection

[calionauta]

🚨 Severity: HIGH
💡 Vulnerability:

1. Broken file exclusion logic in the publish flow allowed sensitive data (like sessions directories and models.json) to be published to public repositories.
2. Regex newline injection vulnerability in skill name validation ($ instead of \Z).

🎯 Impact:

1. Potential exposure of private agent sessions, API keys, and credentials if they are present in the synced directories during a share run (publish) operation.
2. Potential argument injection if validated skill names are passed to shell commands.

🔧 Fix:

1. Refactored _ignore_func in src/agent_sync/publish/git_publish.py to use fnmatch.fnmatch for robust pattern matching.
2. Updated _is_valid_skill_name in src/agent_sync/publish/local_source.py and src/agent_sync/publish/external_source.py to use the \Z anchor.

✅ Verification:

1. Created tests/test_security_remediation.py which includes:
   • Unit tests for the fixed _ignore_func.
   • Unit tests for the fixed regex patterns.
   • Integration test verifying shutil.copytree correctly excludes sensitive files in destination.
2. Ran existing tests/test_security.py and tests/test_publish_git.py to ensure no regressions. All 22 tests passed.

---

PR created automatically by Jules for task 15471328734046121590 started by @renatocaliari

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[gemini-code-assist]

Code Review

This pull request addresses security vulnerabilities by updating skill name validation regexes in both local and external sources to use '\Z' instead of '$', preventing trailing newline bypasses. It also refactors the file exclusion logic in 'git_publish.py' to use the standard 'fnmatch' library for more robust pattern matching, and adds corresponding unit and integration tests. The feedback suggests moving the 'fnmatch' import to the top of the file for cleaner, more idiomatic code.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

While local imports are sometimes used in this codebase to prevent circular dependencies, fnmatch is a standard library module and does not present any circular import risks. It is cleaner and more idiomatic to place this import at the top of the file with the other standard library imports.