Tags: calebho/multipy
Tags
Disable pybind11's GIL checks (pytorch#325) Summary: pybind11 recently added a feature to assert that the GIL is held during reference counting operations pybind/pybind11#4246 This feature has already uncovered several instances of undefined behavior in several Python extensions. However, this code does not seem to pass these checks, which is preventing us from upgrading PyTorch to the latest pybind11. See pytorch/pytorch#105245 This PR disables those checks, which will in turn allow PyTorch to upgrade. Note that this code already has known potential GIL issues: https://github.com/pytorch/multipy/blob/bd1c76f294335695db8bfa66250781c1627f4eb7/multipy/runtime/deploy.cpp#L59 Pull Request resolved: pytorch#325 Reviewed By: PaliC Differential Revision: D47518187 Pulled By: albanD fbshipit-source-id: 5bf14d3633afe67fe0aa8fd74610403e0c494ea5
Disable pybind11's GIL checks (pytorch#325) Summary: pybind11 recently added a feature to assert that the GIL is held during reference counting operations pybind/pybind11#4246 This feature has already uncovered several instances of undefined behavior in several Python extensions. However, this code does not seem to pass these checks, which is preventing us from upgrading PyTorch to the latest pybind11. See pytorch/pytorch#105245 This PR disables those checks, which will in turn allow PyTorch to upgrade. Note that this code already has known potential GIL issues: https://github.com/pytorch/multipy/blob/bd1c76f294335695db8bfa66250781c1627f4eb7/multipy/runtime/deploy.cpp#L59 Pull Request resolved: pytorch#325 Reviewed By: PaliC Differential Revision: D47518187 Pulled By: albanD fbshipit-source-id: 5bf14d3633afe67fe0aa8fd74610403e0c494ea5
Disable pybind11's GIL checks (pytorch#325) Summary: pybind11 recently added a feature to assert that the GIL is held during reference counting operations pybind/pybind11#4246 This feature has already uncovered several instances of undefined behavior in several Python extensions. However, this code does not seem to pass these checks, which is preventing us from upgrading PyTorch to the latest pybind11. See pytorch/pytorch#105245 This PR disables those checks, which will in turn allow PyTorch to upgrade. Note that this code already has known potential GIL issues: https://github.com/pytorch/multipy/blob/bd1c76f294335695db8bfa66250781c1627f4eb7/multipy/runtime/deploy.cpp#L59 Pull Request resolved: pytorch#325 Reviewed By: PaliC Differential Revision: D47518187 Pulled By: albanD fbshipit-source-id: 5bf14d3633afe67fe0aa8fd74610403e0c494ea5
Disable pybind11's GIL checks (pytorch#325) Summary: pybind11 recently added a feature to assert that the GIL is held during reference counting operations pybind/pybind11#4246 This feature has already uncovered several instances of undefined behavior in several Python extensions. However, this code does not seem to pass these checks, which is preventing us from upgrading PyTorch to the latest pybind11. See pytorch/pytorch#105245 This PR disables those checks, which will in turn allow PyTorch to upgrade. Note that this code already has known potential GIL issues: https://github.com/pytorch/multipy/blob/bd1c76f294335695db8bfa66250781c1627f4eb7/multipy/runtime/deploy.cpp#L59 Pull Request resolved: pytorch#325 Reviewed By: PaliC Differential Revision: D47518187 Pulled By: albanD fbshipit-source-id: 5bf14d3633afe67fe0aa8fd74610403e0c494ea5
Disable pybind11's GIL checks (pytorch#325) Summary: pybind11 recently added a feature to assert that the GIL is held during reference counting operations pybind/pybind11#4246 This feature has already uncovered several instances of undefined behavior in several Python extensions. However, this code does not seem to pass these checks, which is preventing us from upgrading PyTorch to the latest pybind11. See pytorch/pytorch#105245 This PR disables those checks, which will in turn allow PyTorch to upgrade. Note that this code already has known potential GIL issues: https://github.com/pytorch/multipy/blob/bd1c76f294335695db8bfa66250781c1627f4eb7/multipy/runtime/deploy.cpp#L59 Pull Request resolved: pytorch#325 Reviewed By: PaliC Differential Revision: D47518187 Pulled By: albanD fbshipit-source-id: 5bf14d3633afe67fe0aa8fd74610403e0c494ea5
Disable pybind11's GIL checks (pytorch#325) Summary: pybind11 recently added a feature to assert that the GIL is held during reference counting operations pybind/pybind11#4246 This feature has already uncovered several instances of undefined behavior in several Python extensions. However, this code does not seem to pass these checks, which is preventing us from upgrading PyTorch to the latest pybind11. See pytorch/pytorch#105245 This PR disables those checks, which will in turn allow PyTorch to upgrade. Note that this code already has known potential GIL issues: https://github.com/pytorch/multipy/blob/bd1c76f294335695db8bfa66250781c1627f4eb7/multipy/runtime/deploy.cpp#L59 Pull Request resolved: pytorch#325 Reviewed By: PaliC Differential Revision: D47518187 Pulled By: albanD fbshipit-source-id: 5bf14d3633afe67fe0aa8fd74610403e0c494ea5
Disable pybind11's GIL checks (pytorch#325) Summary: pybind11 recently added a feature to assert that the GIL is held during reference counting operations pybind/pybind11#4246 This feature has already uncovered several instances of undefined behavior in several Python extensions. However, this code does not seem to pass these checks, which is preventing us from upgrading PyTorch to the latest pybind11. See pytorch/pytorch#105245 This PR disables those checks, which will in turn allow PyTorch to upgrade. Note that this code already has known potential GIL issues: https://github.com/pytorch/multipy/blob/bd1c76f294335695db8bfa66250781c1627f4eb7/multipy/runtime/deploy.cpp#L59 Pull Request resolved: pytorch#325 Reviewed By: PaliC Differential Revision: D47518187 Pulled By: albanD fbshipit-source-id: 5bf14d3633afe67fe0aa8fd74610403e0c494ea5
Disable pybind11's GIL checks (pytorch#325) Summary: pybind11 recently added a feature to assert that the GIL is held during reference counting operations pybind/pybind11#4246 This feature has already uncovered several instances of undefined behavior in several Python extensions. However, this code does not seem to pass these checks, which is preventing us from upgrading PyTorch to the latest pybind11. See pytorch/pytorch#105245 This PR disables those checks, which will in turn allow PyTorch to upgrade. Note that this code already has known potential GIL issues: https://github.com/pytorch/multipy/blob/bd1c76f294335695db8bfa66250781c1627f4eb7/multipy/runtime/deploy.cpp#L59 Pull Request resolved: pytorch#325 Reviewed By: PaliC Differential Revision: D47518187 Pulled By: albanD fbshipit-source-id: 5bf14d3633afe67fe0aa8fd74610403e0c494ea5
Disable pybind11's GIL checks (pytorch#325) Summary: pybind11 recently added a feature to assert that the GIL is held during reference counting operations pybind/pybind11#4246 This feature has already uncovered several instances of undefined behavior in several Python extensions. However, this code does not seem to pass these checks, which is preventing us from upgrading PyTorch to the latest pybind11. See pytorch/pytorch#105245 This PR disables those checks, which will in turn allow PyTorch to upgrade. Note that this code already has known potential GIL issues: https://github.com/pytorch/multipy/blob/bd1c76f294335695db8bfa66250781c1627f4eb7/multipy/runtime/deploy.cpp#L59 Pull Request resolved: pytorch#325 Reviewed By: PaliC Differential Revision: D47518187 Pulled By: albanD fbshipit-source-id: 5bf14d3633afe67fe0aa8fd74610403e0c494ea5
Fix broken test Summary: This test seems to be broken for at least a month and is blocking S343974 Specifically, the fbpkg builds are blocked by this: https://www.internalfb.com/intern/sandcastle/job/27021598739017954 Reviewed By: gunchu Differential Revision: D46848358 fbshipit-source-id: 4109c6bf909594dc42543a986e4c55398fcb2f07
PreviousNext