Skip to content

Added initial DFA notebook. #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

eliotwrobson
Copy link
Collaborator

@eliotwrobson eliotwrobson commented Jul 27, 2024

Addition of self-contained example notebooks explaining finite automata theory using the library. More complete version of #212. Only the DFA notebook so far. Math isn't rendering because of this issue: danielfrg/mkdocs-jupyter#143

We may have to wait till that's fixed before merging.

cc @skyien-z

---------

Co-authored-by: Kylie Zhang <luckiskyi@gmail.com>
@eliotwrobson eliotwrobson self-assigned this Jul 27, 2024
@eliotwrobson eliotwrobson changed the base branch from main to develop July 27, 2024 18:25
@coveralls
Copy link

coveralls commented Jul 27, 2024

Coverage Status

coverage: 99.613%. remained the same
when pulling 79d542c on eliotwrobson:example_notebook
into b2d3342 on caleb531:develop.

@eliotwrobson eliotwrobson marked this pull request as ready for review January 23, 2025 23:17
@eliotwrobson
Copy link
Collaborator Author

@caleb531 how do you think we should go about adding this? It doesn't look like we can really add this notebook to the docs site until the math display is working, but I think the github jupyter notebook browser is sufficient. Should we just add a link to the docs site?

@caleb531
Copy link
Owner

caleb531 commented Feb 6, 2025

@eliotwrobson Yeah, I think just adding a link to the Docs site for now is fine.

@eliotwrobson
Copy link
Collaborator Author

@caleb531 sounds good! Added the link and will go ahead and merge, since I edited the notebook earlier.

@eliotwrobson eliotwrobson merged commit 050e027 into caleb531:develop Feb 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants